Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear reset timer on open() #383

Merged
merged 3 commits into from
Oct 28, 2019
Merged

Clear reset timer on open() #383

merged 3 commits into from
Oct 28, 2019

Conversation

tjenkinson
Copy link
Contributor

If open() is called I think the reset timer should be reset, as the intent is probably for the circuit breaker to remain open until close() is called.

lance
lance approved these changes Oct 28, 2019
View reviewed changes
Copy link
Member

@lance lance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks again for your contributions!

@lance lance added the bug label Oct 28, 2019
@lholmquist lholmquist merged commit 7f488f1 into nodeshift:master Oct 28, 2019
@mnutt mnutt mentioned this pull request Nov 5, 2019
Closed
This was referenced Apr 7, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lholmquist lholmquist lholmquist approved these changes

@lance lance lance approved these changes

@helio-frota helio-frota Awaiting requested review from helio-frota

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tjenkinson @lance @lholmquist